Python: omit failed Foundry turns from conversation chat history - #7637

@microsoft-github-policy-service agree

Unfortunately this doesn't fix the issue, as the problem is that the messages get saved to the chat history, not the session.

You're right — the first commit skipped the wrong store.

The agentserver response provider was persisting input items for failed turns, so the next request on the same conversation replayed them via chat history (get_history()), not the MAF session.

24ebe8b wraps the response store so failed turns persist without input items (including the in_progress → failed update path). A follow-up request on the same conversation no longer sees the bad function_call_output. Tests cover both the store wrapper and the HTTP conversation repro from the issue.

Python Unit Test Overview

/review

Shikhar Goel (@sgoel2be24-cyber) please fix the merge conflict, and there is a update coming to the way we handle storage in #7997 I suggest updating this after that one merged

Thanks Eduard van Valkenburg (@eavanvalkenburg). The merge conflict is fixed: rebased onto main (1a51fdd) and pushed 79aa6e3, including the prepared docstring and concrete-type cleanup. Foundry Hosting validation passes: 276 unit tests, 90% package coverage, Ruff, strict Pyright, and all five test type-checkers. The two cleanup threads are resolved; the streaming/storage thread remains open. I will revisit that design after #7997 merges, as suggested.

Follow-up: #7997 merged while I was validating the earlier update. I have now rebased onto it (1f7f4b3) and pushed 8213cc6. Failed-input filtering is scoped to regular agents using AgentServer history; agent-owned history retains normal protocol storage and bypasses buffering. Added regression coverage for both modes and updated the resilient-store guard test for the new constructor validation order. All 294 Foundry Hosting unit tests pass, with 91% coverage; Ruff, strict Pyright, and all five test type-checkers pass. The docstring/type cleanup remains complete. The remaining default-mode buffering/API question is documented in the open review thread.

/review